stuzer05/roundcube-easy-unsubscribe
1
0
Fork 0
Code Issues Pull Requests Releases Activity

Improve list-unsubscribe parsing

Browse Source 
- Supports multiple URIs
- Fixes bug with URLs not working
- Escapes URI to avoid XSS injections from header
This commit is contained in:
Tom Sommer 2019-08-25 13:27:58 +02:00 committed by GitHub
parent 08679a4df1
commit 95b9bb15c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
easy_unsubscribe.php
View File

@ -29,16 +29,11 @@ class easy_unsubscribe extends rcube_plugin
$this->message_headers_done = true; $this->message_headers_done = true;
$ListUnsubscribe = $p['headers']->others['list-unsubscribe']; $ListUnsubscribe = $p['headers']->others['list-unsubscribe'];
if ( preg_match_all('/<(.+)>/mU', $ListUnsubscribe, $items, PREG_PATTERN_ORDER) ) {
preg_match('%\bhttps?://[^,\s()<>]+(?:\([\w\d]+\)|([^,[:punct:]\s]|/))%i', $ListUnsubscribe, $UnsubURL); foreach ( $items[1] as $uri ) {
preg_match('/mailto:(.*?)>/', $ListUnsubscribe, $UnsubEmail); $this->unsubscribe_img .= '<a class="easy_unsubscribe_link tooltip-right" data-tooltip="Click to unsubscribe" href="'. htmlentities($uri) .'" target="_blank" onclick="return confirm(\'Are you sure you want to unsubscribe?\');"><img src="plugins/easy_unsubscribe/icon.png" alt="Unsubscribe" /></a>';
}
if(!empty($UnsubURL[0])) }
$this->unsubscribe_img = '<a class="easy_unsubscribe_link tooltip-right" data-tooltip="Unsubscribe via URL" href="'.$UnsubEmail[0].'" target="_blank" onclick="return confirm(\'Are you sure you want to unsubscribe?\');"><img src="plugins/easy_unsubscribe/icon.png" alt="Unsubscribe" /></a>';
if(!empty($UnsubEmail[1]))
$this->unsubscribe_img .= '<a class="easy_unsubscribe_link tooltip-right" data-tooltip="Unsubscribe via Email" href="'.$UnsubEmail[1].'" target="_blank" onclick="return confirm(\'Are you sure you want to unsubscribe?\');"><img src="plugins/easy_unsubscribe/icon.png" alt="Unsubscribe" /></a>';
} }
if(isset($p['output']['subject'])) if(isset($p['output']['subject']))